Skip to content

feat: Storage accessible unit tests#156

Merged
fedgiac merged 3 commits intocowprotocol:mainfrom
kamuik16:kamuik16/storage-accessible-test
Jun 6, 2024
Merged

feat: Storage accessible unit tests#156
fedgiac merged 3 commits intocowprotocol:mainfrom
kamuik16:kamuik16/storage-accessible-test

Conversation

@kamuik16
Copy link
Copy Markdown
Contributor

@kamuik16 kamuik16 commented Jun 5, 2024

Closes #145 #147

@kamuik16 kamuik16 requested a review from a team as a code owner June 5, 2024 07:38
Copy link
Copy Markdown
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The license issue is still open, sorry about that.

@kamuik16 kamuik16 requested a review from fedgiac June 5, 2024 15:02
@kamuik16
Copy link
Copy Markdown
Contributor Author

kamuik16 commented Jun 6, 2024

@fedgiac I have implemented your suggestions. Thanks!

Copy link
Copy Markdown
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution!

@fedgiac fedgiac merged commit c3ff8dc into cowprotocol:main Jun 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
@kamuik16 kamuik16 deleted the kamuik16/storage-accessible-test branch June 6, 2024 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests(core): StorageAccessible

2 participants